[pHash-support] threading related bugs

[Evan Klinger]

Mostafa,

Thank you for submitting your patch. However, I believe the correct
fix in the multithreaded audio function is to pass NULL as the buf and
the readaudio() function will create the buffer for you and return it.
Can you explain your fix in the multithreaded image hash function? The
off variable is really the absolute starting position for the
subsequent thread and not an offset that should be added to start.
Please provide a test case where the function fails to set start
correctly.

Thank you
Evan

On Fri, Jun 11, 2010 at 11:53 AM, Mostafa Razavi <hom.sepanta at gmail.com> wrote:
> Hi. I'm a new user of pHash and I just encountered two bugs in threading
> related codes. I think the patch is self-explanatory (only two lines have
> been changed). I made the patch against current source tarball (0.9.0).
>
> Cheers,
> Mostafa Razavi
>
>
> _______________________________________________
> pHash-support mailing list
> pHash-support at lists.phash.org
> http://lists.phash.org/listinfo.cgi/phash-support-phash.org
>
>